Re: [PATCH 06/15] staging: xgifb: delete bIntegratedMMEnabled

From: Dan Carpenter
Date: Wed Mar 09 2011 - 06:09:24 EST


On Wed, Mar 09, 2011 at 10:23:01AM +0200, Aaro Koskinen wrote:
> Hi,
>
> On Wed, 9 Mar 2011, Dan Carpenter wrote:
> >On Tue, Mar 08, 2011 at 10:16:11PM +0200, Aaro Koskinen wrote:
> >>bIntegratedMMEnabled is always true, so the field and checks can be
> >>eliminated.
> >>
> >What about for the chips that came before the XG40? Are we dropping
> >support for them?
>
> They were never supported. See the earlier switch (xgi_video_info.chip_id)
> statement in the probe routine - it will return -ENODEV for other chips
> than XG40..XG27.
>

Ah... That's true. This patch is fine by me then.

Reviewed-by: Dan Carpenter <error27@xxxxxxxxx>

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/