Re: [PATCH][RFC] tracing: Enable tracepoints via module parameters

From: Yuanhan Liu
Date: Tue Mar 08 2011 - 21:01:54 EST


On Tue, Mar 08, 2011 at 07:52:04PM -0500, Steven Rostedt wrote:
> On Tue, 2011-03-08 at 19:29 -0500, Mathieu Desnoyers wrote:
> > * Steven Rostedt (rostedt@xxxxxxxxxxx) wrote:
> > > On Tue, 2011-03-08 at 19:07 -0500, Mathieu Desnoyers wrote:

[snip]

> >
> > >
> > > If you want to enable a tracepoint on module load simply do:
> > >
> > > modprobe mymod trace_my_tracepoint=1
> > >
> > > Otherwise modify your modprobe.d directory. This is the way users have
> > > been doing module parameters for years.
> > >
> > > That's pretty simple to me.
> >
> > Everything is always so much easier when your end-user target is yourself.
> > What are users for anyway ? :-P
>
> Users are for testing code ;)

As another end-user, this looks fine (also simple) to me ;)

>
> But that's a good question. As I wrote this because I'm purging my inbox
> and came across Yuanhan Liu's patch set. I'm curios to what Yuanhan's
> motivation for this change was.

The motivation of my original patch is simple: try to not miss any trace
events. I guess it's a kind of feature that trace(or module) should
have ;)


Thanks,
Yuanhan Liu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/