Re: [PATCH 1/3] mfd: add a core driver for TI TPS61050/TPS61052chips

[Mark Brown]

On Tue, Mar 08, 2011 at 10:40:41AM +0100, Linus Walleij wrote:

> +config TPS6105X
> +	tristate "TPS61050/61052 Boost Converters"
> +	depends on I2C && EXPERIMENTAL

Why EXPERIMENTAL?

> +	select REGULATOR
> +	select REGULATOR_FIXED_VOLTAGE

> +	default y if MACH_U8500

Not sure I'm enthusiastic about that - it's sensible for the machine to
want that but I can see this getting out of hand if you've got a lot of
machines doing that.  Perhaps have the machine select the regulator for
builds with REGULATOR enabled?

> +	/* Put the chip in SHUTDOWN mode */
> +	ret = tps6105x_mask_and_set(tps6105x, TPS6105X_REG_0,
> +		TPS6105X_REG0_MODE_MASK,
> +		TPS6105X_REG0_MODE_SHUTDOWN << TPS6105X_REG0_MODE_SHIFT);
> +	if (ret)
> +		return ret;

I'm not sure this is what we want.  If the device is driving the
backlight it'll result in the backlight flashing off during boot which
doesn't seem desirable.  The standard thing is just to inherit the
hardware state.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/