Re: [cpuops cmpxchg double V3 3/5] Generic support forthis_cpu_cmpxchg_double

From: Christoph Lameter
Date: Fri Feb 25 2011 - 15:44:22 EST


On Fri, 25 Feb 2011, Steven Rostedt wrote:

> > + VM_BUG_ON((unsigned long)(&pcp1) % (2 * sizeof(pcp1))); \
> > + VM_BUG_ON((unsigned long)(&pcp2) != (unsigned long)(&pcp1) + sizeof(pcp1));\
> > + VM_BUG_ON(sizeof(pcp1) != sizeof(pcp2)); \
>
> Since this is a macro, and it looks like all these are constants (sizeof
> and addresses), couldn't you just do a BUILD_BUG_ON() instead?

The addresses are not constant.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/