Re: [PATCH v2 2/3] sdhci-pci : Enable runtime PM support

From: Matthew Garrett
Date: Fri Feb 25 2011 - 09:55:05 EST


On Fri, Feb 25, 2011 at 07:33:12AM +0000, Tardy, Pierre wrote:

> My understanding is the pci driver is not supposed to do any set_power_state/pci_save_state/wake_enable.
> Everything is supposed to be generically handle by pci frameworks's runtime_pm impl.
> Need confirmation from Rafael.

The core can only enable PME generation, it can't configure what
generates PMEs. There's a register in sdhci that needs to be programmed
to enable wakeups on card insert/removal/interrupt. If you don't then
you won't get a PME no matter what the core does.

--
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/