Re: [PATCH] eeepc-wmi: set the touchpad toggle key code to F21

[Corentin Chary]

On Fri, Feb 25, 2011 at 6:19 AM, Keng-Yu Lin <keng-yu.lin@xxxxxxxxxxxxx> wrote:
> Signed-off-by: Keng-Yu Lin <keng-yu.lin@xxxxxxxxxxxxx>
> ---
> Âdrivers/platform/x86/eeepc-wmi.c | Â Â2 +-
> Â1 files changed, 1 insertions(+), 1 deletions(-)
>
> https://bugs.freedesktop.org/show_bug.cgi?id=31333
>
> diff --git a/drivers/platform/x86/eeepc-wmi.c b/drivers/platform/x86/eeepc-wmi.c
> index d399775..da00cbc 100644
> --- a/drivers/platform/x86/eeepc-wmi.c
> +++ b/drivers/platform/x86/eeepc-wmi.c
> @@ -113,7 +113,7 @@ static const struct key_entry eeepc_wmi_keymap[] = {
> Â Â Â Â{ KE_KEY, 0x32, { KEY_MUTE } },
> Â Â Â Â{ KE_KEY, 0x5c, { KEY_F15 } }, /* Power Gear key */
> Â Â Â Â{ KE_KEY, 0x5d, { KEY_WLAN } },
> - Â Â Â { KE_KEY, 0x6b, { KEY_F13 } }, /* Disable Touchpad */
> + Â Â Â { KE_KEY, 0x6b, { KEY_F21 } }, /* Disable Touchpad */
> Â Â Â Â{ KE_KEY, 0x82, { KEY_CAMERA } },
> Â Â Â Â{ KE_KEY, 0x83, { KEY_CAMERA_ZOOMIN } },
> Â Â Â Â{ KE_KEY, 0x88, { KEY_WLAN } },

Hum, I'm not very comfortable with this patch now that we got
KEY_TOUCHPAD_TOGGLE.
I know, it doesn't work with current Xorg, but if we continue to
workaround that, it'll never be fixed.

Dmitry, Matthew, any advice ?
-- 
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/