Re: [PATCH] staging: gma500: Fix compilation error.

[Greg KH]

On Thu, Feb 24, 2011 at 08:58:52PM +0100, Belisko Marek wrote:
> Hi Greg,
> 
> On Thu, Feb 24, 2011 at 6:12 PM, Greg KH <gregkh@xxxxxxx> wrote:
> > On Thu, Feb 24, 2011 at 10:33:18AM +0100, Marek Belisko wrote:
> >> This patch will fix following compilation error:
> >> drivers/staging/gma500/psb_drv.c:1635: error: unknown field âpci_driverâ specified in initializer
> >> drivers/staging/gma500/psb_drv.c:1636: error: unknown field ânameâ specified in initializer
> >> drivers/staging/gma500/psb_drv.c:1636: warning: initialization from incompatible pointer type
> >> drivers/staging/gma500/psb_drv.c:1637: error: unknown field âid_tableâ specified in initializer
> >> drivers/staging/gma500/psb_drv.c:1637: warning: excess elements in union initializer
> >> drivers/staging/gma500/psb_drv.c:1637: warning: (near initialization for âdriver.kdriverâ)
> >> drivers/staging/gma500/psb_drv.c:1638: error: unknown field âresumeâ specified in initializer
> >> drivers/staging/gma500/psb_drv.c:1638: warning: excess elements in union initializer
> >> drivers/staging/gma500/psb_drv.c:1638: warning: (near initialization for âdriver.kdriverâ)
> >> drivers/staging/gma500/psb_drv.c:1639: error: unknown field âsuspendâ specified in initializer
> >> drivers/staging/gma500/psb_drv.c:1639: warning: excess elements in union initializer
> >> drivers/staging/gma500/psb_drv.c:1639: warning: (near initialization for âdriver.kdriverâ)
> >> drivers/staging/gma500/psb_drv.c:1640: error: unknown field âprobeâ specified in initializer
> >> drivers/staging/gma500/psb_drv.c:1640: warning: excess elements in union initializer
> >> drivers/staging/gma500/psb_drv.c:1640: warning: (near initialization for âdriver.kdriverâ)
> >> drivers/staging/gma500/psb_drv.c:1641: error: unknown field âremoveâ specified in initializer
> >> drivers/staging/gma500/psb_drv.c:1641: warning: excess elements in union initializer
> >> drivers/staging/gma500/psb_drv.c:1641: warning: (near initialization for âdriver.kdriverâ)
> >> drivers/staging/gma500/psb_drv.c:1643: error: unknown field âdriverâ specified in initializer
> >> drivers/staging/gma500/psb_drv.c:1643: warning: excess elements in union initializer
> >> drivers/staging/gma500/psb_drv.c:1643: warning: (near initialization for âdriver.kdriverâ)
> >> drivers/staging/gma500/psb_drv.c: In function âpsb_initâ:
> >> drivers/staging/gma500/psb_drv.c:1664: error: implicit declaration of function âdrm_initâ
> >> drivers/staging/gma500/psb_drv.c: In function âpsb_exitâ:
> >> drivers/staging/gma500/psb_drv.c:1669: error: implicit declaration of function âdrm_exitâ
> >>
> >> Signed-off-by: Marek Belisko <marek.belisko@xxxxxxxxxxxxxxx>
> >
> > Odd, how come I'm not hitting these in the staging-next tree? ÂIs it
> > because an api changed in the DRM layer in the linux-next tree?
> Yes DRM api was changed:
> commit 8410ea3b95d105a5be5db501656f44bbb91197c1
> Author: Dave Airlie <airlied@xxxxxxxxx>
> Date:   Wed Dec 15 03:16:38 2010 +1000
> 
>     drm: rework PCI/platform driver interface.
> 
> Introduce union kdriver which encapsulate pci_driver struct.
> That's cause of error in gma500.

Ok, this is going to get messy then, this patch should be held by
Stephen in linux-next until we merge stuff with Linus, and then I'll be
able to apply it to my tree.  So I'll just save it in my queue until
that time happens, thanks.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/