Re: [PATCH RFC tip/core/rcu 11/11] rcu: move TREE_RCU from softirqto kthread

From: Paul E. McKenney
Date: Wed Feb 23 2011 - 13:52:51 EST


On Wed, Feb 23, 2011 at 09:02:01AM -0500, Mathieu Desnoyers wrote:
> * Paul E. McKenney (paulmck@xxxxxxxxxxxxxxxxxx) wrote:
> [...]
> > + for (cpu = rnp->grplo; cpu <= rnp->grphi; cpu++, mask <<= 1)
> > + if (mask & 01)
>
> Wow, octal notation! ;)

/me pauses to thank the octal-notation PDP-12, CDC 3300, CDC Cyber 73,
and PDP-11 systems for funding my college education. The two CDC
systems had ones-complement in the bargain. ;-)

> Maybe we could consider 0x1 here.

Good catch, fixed. The hex says "bitmask" to me.

Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/