Re: [PATCH 2/5] x86: Minimize initial e820 messages

From: Ingo Molnar
Date: Fri Feb 18 2011 - 02:30:56 EST



* Mike Travis <travis@xxxxxxx> wrote:

> --- linux.orig/arch/x86/kernel/e820.c
> +++ linux/arch/x86/kernel/e820.c
> @@ -38,6 +38,8 @@
> */
> struct e820map e820;
> struct e820map e820_saved;
> +struct e820map e820_prev __initdata;
> +int e820_prev_saved __initdata;

Please add comments to the code that describe what these global variables do.

Also, they should be 'static' as they are only used in e820.c, right?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/