Re: [PATCH] usb_storage: realtek_cr patch: fix sparse warning

From: Jiri Slaby
Date: Tue Feb 15 2011 - 03:51:07 EST


On 02/15/2011 02:38 AM, wei_wang@xxxxxxxxxxxxxx wrote:
> From: wwang <wei_wang@xxxxxxxxxxxxxx>
>
> Fix some sparse warning for realtek_cr patch
>
> Signed-off-by: wwang <wei_wang@xxxxxxxxxxxxxx>
> ---
> drivers/usb/storage/realtek_cr.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/storage/realtek_cr.c b/drivers/usb/storage/realtek_cr.c
> index c2bebb3..4f6b25f 100644
> --- a/drivers/usb/storage/realtek_cr.c
> +++ b/drivers/usb/storage/realtek_cr.c
> @@ -141,7 +141,7 @@ static int init_realtek_cr(struct us_data *us);
> .driver_info = (flags)|(USB_US_TYPE_STOR<<24)\
> }
>
> -struct usb_device_id realtek_cr_ids[] = {
> +static struct usb_device_id realtek_cr_ids[] = {

And it may be const too while you are at it...

regards,
--
js
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/