Re: char/ipmi: cleanup_one_si section mismatch

From: Corey Minyard
Date: Mon Feb 14 2011 - 18:30:16 EST


Yeah, I should have noticed this.

Acked-by: Corey Minyard <cminyard@xxxxxxxxxx>

On 02/14/2011 09:03 AM, Sergey Senozhatsky wrote:
Hello,

commit d2478521afc20227658a10a8c5c2bf1a2aa615b3
Author: Corey Minyard<minyard@xxxxxxx>
Date: Thu Feb 10 16:08:38 2011 -0600

char/ipmi: fix OOPS caused by pnp_unregister_driver on unregistered driver


Introduced section mismatch by calling __exit cleanup_ipmi_si
from __devinit init_ipmi_si. Should we remove __exit annotation then?


---

drivers/char/ipmi/ipmi_si_intf.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index 7855f9f..94cd2ce 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -3532,7 +3532,7 @@ static void cleanup_one_si(struct smi_info *to_clean)
kfree(to_clean);
}

-static void __exit cleanup_ipmi_si(void)
+static void cleanup_ipmi_si(void)
{
struct smi_info *e, *tmp_e;



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/