Re: [BISECTED] commit 619efb1059 makes the MacBookPro2,2 screen flicker like its broken or half plugged in

From: Justin Mattock
Date: Sun Feb 13 2011 - 20:15:07 EST



On Feb 13, 2011, at 3:46 PM, Alex Deucher wrote:

On Sun, Feb 13, 2011 at 12:28 AM, Justin Mattock
<justinmattock@xxxxxxxxx> wrote:

On Feb 11, 2011, at 5:15 PM, Alex Deucher wrote:

On Fri, Feb 11, 2011 at 10:57 AM, Justin Mattock
<justinmattock@xxxxxxxxx> wrote:


Better yet, can you try the attached patch on top of 2.6.38-rc4 or
newer?

Alex


o.k. applied that patch... unfortunately Im seeing the flickering screen
and
the crud shows up..
initially during boot everything looked fine, its when I suspended the
machine, upon wake-up
the flickering occurred.
kernel version is the current: 2.6.38-rc4-00107-gaa502b4

Can you try this patch? Try uncommenting the following lines to see
if either of those flags work any better. Try them individually and
together if possible and report back which, if any, helps.

/*pll->flags |= RADEON_PLL_PREFER_MINM_OVER_MAXP;*/

/*if (ASIC_IS_AVIVO(rdev))
pll->flags |= RADEON_PLL_USE_FRAC_FB_DIV;*/

Thanks!

Alex


Justin P. Mattock

<0001-drm-radeon-kms-hopefully-fix-pll-issues-for-real-v2.patch>


alright.. again out of my office trying to make a living!!
Anyways I applied the two earlier patches, and added the previous post's
patch as well
(everything runs o.k. s2r etc...)
I can try for the above and see if I can pinpoint the piece of code that is
causing this(hopefully)

The attached patch is what I'm proposing to go upstream. Please test
and let me know if it works ok for you.

Alex


alright... bisect done, but something went wrong(must redu later).. Anyways with your patch applied
everything looks good

Justin P. Mattock
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/