Re: [PATCH] usb: gadget: f_mass_storage: fixed a macro codingstyle issue

From: Greg KH
Date: Sat Feb 12 2011 - 11:04:29 EST


On Sat, Feb 12, 2011 at 04:15:21PM +0800, yenchengwang wrote:
> ah, I think I made a mistake...
> I watched this video
> http://archive.fosdem.org/2010/schedule/events/linuxkernelpatch,
> then tried the ./scripts/checkpatch.pl and see two ERROR:...
> so ... sent this patch, I apologize for my mistake, :(

That's great to do that, but you forgot the part of that talk that
showed you had to build your patch to verify that you did not break
anything. Please do that in the future.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/