[PATCH][RFC] infiniband: Fix allocation size inregister_snoop_agent()

From: Jesper Juhl
Date: Fri Feb 11 2011 - 16:45:28 EST


Ok, someone needs to double check me on this before merging anything, but
don't we want to allocate sizeof(struct ib_mad_snoop_private) here, rather
than just the size of a pointer to the struct?

Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx>
---
mad.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

compile tested only. no hardware available for proper test.

diff --git
a/drivers/infiniband/core/mad.c
b/drivers/infiniband/core/mad.c
index 822cfdc..2c74b85 100644
--- a/drivers/infiniband/core/mad.c
+++ b/drivers/infiniband/core/mad.c
@@ -413,7 +413,7 @@ static int register_snoop_agent(struct ib_mad_qp_info *qp_info,
if (i == qp_info->snoop_table_size) {
/* Grow table. */
new_snoop_table = krealloc(qp_info->snoop_table,
- sizeof mad_snoop_priv *
+ sizeof(struct ib_mad_snoop_private) *
(qp_info->snoop_table_size + 1),
GFP_ATOMIC);
if (!new_snoop_table) {


--
Jesper Juhl <jj@xxxxxxxxxxxxx> http://www.chaosbits.net/
Plain text mails only, please.
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/