Re: [PATCH] mtd: jedec_probe: initialise make sector erase command variable

[Guillaume LECERF]

Hello.

2011/2/11 Antony Pavlov <antony@xxxxxxxxxxxx>:
> In the commit 08968041bef437ec363623cd3218c2b083537ada
> Â(mtd: cfi_cmdset_0002: make sector erase command variable)
> introdused a field sector_erase_cmd. In the same commit initialisation
> of cfi->sector_erase_cmd made in cfi_chip_setup()
> (file drivers/mtd/chips/cfi_probe.c), so the CFI chip has no problem:
>
> ...
> Â Â Â Âcfi->cfi_mode = CFI_MODE_CFI;
> Â Â Â Âcfi->sector_erase_cmd = CMD(0x30);
> ...
>
> But for the JEDEC chips this initialisation is not carried out,
> so the JEDEC chips have sector_erase_cmd == 0.
>
> It's not possible symply add the line
> Â Â Â Âp_cfi->sector_erase_cmd = CMD(0x30);
> to the cfi_jedec_setup() function be cause CMD() macros needs
> map and cfi variables. So this patch makes necessary changes.
>
> Signed-off-by: Antony Pavlov <antony@xxxxxxxxxxxx>

Acked-by: Guillaume LECERF <glecerf@xxxxxxxxx>

-- 
Guillaume LECERF
GeeXboX developer - www.geexbox.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/