Re: [PATCH 00/30] amd64_edac: Add Bulldozer support

[Borislav Petkov]

On Thu, Feb 10, 2011 at 11:22:49AM -0800, Jesse Barnes wrote:
> > Jesse, do you want the patch at
> > http://marc.info/?l=linux-edac&m=129735827731488&w=2 rerouted over your
> > tree or would you rather ack it?
> 
> You can have my ack:
> 
> Acked-by: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>

Thanks.

> Though if that's the only place that PCI ID is used, you may as well
> just put it into the corresponding file and remove it from pci_ids.h
> altogether.

Yeah, this patchset adds another user of PCI_DEVICE_ID_AMD_15H_NB_F3 in
amd64_edac.c, this was the reasoning to move it to pci_ids.h

In contrast, I'm also introducing PCI_DEVICE_ID_AMD_15H_NB_F[12] which
are used only in this driver and thus I've left them in its header.
We'll move them to pci_ids.h only if some other user of them appears.

Thanks.

-- 
Regards/Gruss,
    Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/