Re: [RFC PATCH 06/13] Intel(R) MEI Driver

From: Alan Cox
Date: Thu Feb 10 2011 - 08:49:13 EST


> +/**
> + * flow_ctrl_creds - checks flow_control credentials.

There seem to be an enormous number of global variables and not all of
them have mei_xxx prefixes on either.

I can't tell if this is because the driver wants restructuring as there
simply isn't an overall visible architecture or design to the code I can
see, nor any documentation on what it is doing at the higher levels or
the API.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/