Re: [PATCH] scsi: make scsi_devinfo infrastructure optional

From: James Bottomley
Date: Wed Feb 09 2011 - 13:00:24 EST


On Wed, 2011-02-09 at 15:15 +0100, Bartlomiej Zolnierkiewicz wrote:
> Add SCSI_QUIRKS config option (default y and dependent on EMBEDDED
> config option) to allow disabling of scsi_devinfo infrastructure.
>
> The output code size savings are ~14k for CONFIG_SCSI_QUIRKS=n
> (as measured on x86-32):

I don't understand the point of this patch ... without the quirks SCSI
will do the wrong thing on a whole bunch of stuff. The savings look to
be tiny ... since the SCSI module is habitually a lot larger than your
figures suggest.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/