Re: [RFC v2 PATCH 1/7] matrix_keypad: Increase the max limit of rowsand columns

[Eric Miao]

On Tue, Feb 1, 2011 at 9:47 PM, Anirudh Ghayal <aghayal@xxxxxxxxxxxxxx> wrote:
> From: Trilok Soni <tsoni@xxxxxxxxxxxxxx>
>
> Some keyboard controller have support for more than
> 16 columns and rows. Moving this value to 32.
>
> Cc: Eric Miao <eric.y.miao@xxxxxxxxx>
> Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> Signed-off-by: Trilok Soni <tsoni@xxxxxxxxxxxxxx>

This looks good to me, as long as the bits don't exceed 256, which
is used in the #KEY() macro. So far, 32 looks to be a sane number
to me, unless we have further requirement to get this larger.

Acked-by: Eric Miao <eric.y.miao@xxxxxxxxx>


> ---
> Changes from v1:
> Moved the max columns and rows to 32
>
> Âinclude/linux/input/matrix_keypad.h | Â Â4 ++--
> Â1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/input/matrix_keypad.h b/include/linux/input/matrix_keypad.h
> index 6974746..fe7c4b9 100644
> --- a/include/linux/input/matrix_keypad.h
> +++ b/include/linux/input/matrix_keypad.h
> @@ -4,8 +4,8 @@
> Â#include <linux/types.h>
> Â#include <linux/input.h>
>
> -#define MATRIX_MAX_ROWS Â Â Â Â Â Â Â Â16
> -#define MATRIX_MAX_COLS Â Â Â Â Â Â Â Â16
> +#define MATRIX_MAX_ROWS Â Â Â Â Â Â Â Â32
> +#define MATRIX_MAX_COLS Â Â Â Â Â Â Â Â32
>
> Â#define KEY(row, col, val) Â Â ((((row) & (MATRIX_MAX_ROWS - 1)) << 24) |\
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â (((col) & (MATRIX_MAX_COLS - 1)) << 16) |\
> --
> 1.7.3.5
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/