Re: [PATCH] pch_gbe: Fix the issue which a driver locks when rxoffload is set by ethtool

[David Miller]

From: "Toshiharu Okada" <toshiharu-linux@xxxxxxxxxxxxxxx>
Date: Wed, 9 Feb 2011 11:04:11 +0900

> From: David Miller <davem@xxxxxxxxxxxxx>
> Date: Tue, 08 Feb 2011 16:40:30 -0800 (PST)
> 
>>> @@ -531,12 +533,8 @@ void pch_gbe_reinit_locked(struct pch_gbe_adapter 
>>> *adapter)
>>>  {
>>>  struct net_device *netdev = adapter->netdev;
>>>
>>> - rtnl_lock();
>>> - if (netif_running(netdev)) {
>>> - pch_gbe_down(adapter);
>>> - pch_gbe_up(adapter);
>>> - }
>>> - rtnl_unlock();
>>> + pch_gbe_down(adapter);
>>> + pch_gbe_up(adapter);
>>
>>Are you sure you can just blindly delete the netif_running() check here?
> 
> Yes, sure.
> pch_gbe_reinit_locked() is called after confirming of netif_running() except 
> for pch_gbe_reset_task() function.
> This netif_running() was redundant.

Thanks for explaining, applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/