Re: [PATCH] pch_gbe: Fix the issue that the receiving data is notnormal.

From: David Miller
Date: Tue Feb 08 2011 - 19:34:54 EST


From: Toshiharu Okada <toshiharu-linux@xxxxxxxxxxxxxxx>
Date: Tue, 08 Feb 2011 17:24:10 +0900

> Hi Devid
>
> I resubmit this patch modified.
> Please check them.

Your memcpy+memcpy sequences are equivalent to memmove(), please
use that instead.

I have to say this function is insanely complicated. There seems
to be 16 different ways RX packets are processed. I can't believe
that is needs to be like this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/