Re: [patch 0/8] ia64: Convert irq_chips to new functions

[Thomas Gleixner]

On Mon, 7 Feb 2011, Tony Luck wrote:

> On Sat, Feb 5, 2011 at 11:44 AM, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> > The following series converts the interrupt chips to the new
> > functions.Compile tested only.
> 
> I see a new warning while building:
> 
> arch/ia64/sn/kernel/irq.c:427: warning: ‘force_interrupt’ defined but not used

Oops
 
> since you deleted the only use of this function.
> sn_force_interrupt_flag doesn't
> seem to be useful either once this patch has been applied.
 
Agreed.

> Apart from that it all seems to build and boot with no problems on my
> machine.  I haven't tested on SGI sn2 system (where you've made
> a moderately big change).  It'd be nice to get an Ack from there.

That might take a while. I fear Jes is skiing this week, IIRC.

Thanks,

	tglx