Re: [PATCH] KVM: x86: Convert tsc_write_lock to raw_spinlock

From: Avi Kivity
Date: Mon Feb 07 2011 - 10:52:49 EST


On 02/07/2011 05:38 PM, Jan Kiszka wrote:
>
> I don't know as it is allowed to sleep, it doesn't call any sleeping
> functions to my knowledge. What worries me in the RT case is that the
> spinlock acquired for hardware_enable might be preempted and run on
> another CPU, which obviously isn't what you want.

I see now, there are calls to raw_smp_processor_id.

I think it's best to make this a raw lock. At this chance, some
read-only users of vm_list should be rcu'ified. Will have a look.

vm_list is rarely used, for either read or write. I don't see the need to rcu it.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/