Re: [PATCH] Export linux/syslog.h

From: Arnd Bergmann
Date: Mon Feb 07 2011 - 07:56:34 EST


On Monday 07 February 2011, Paul Bolle wrote:
> Userspace programs (like util-linux' dmesg) still use magic numbers for
> the klogctl function (glibc's interface to the syslog system call).
> Exporting linux/syslog.h makes the more descriptive named constants
> available as a single reference for these values.
>
> Signed-off-by: Paul Bolle <pebolle@xxxxxxxxxx>
> Signed-off-by: Kees Cook <kees.cook@xxxxxxxxxxxxx>

It sounds reasonable to make this a proper ABI in general.

The comment in the header file currently starts with "Syslog internals".
If you want to export it, you should probably change that, too.
Further, the man page currently documents the raw numbers and should
be changed as well with the new constants.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/