Re: Sun GEM PPC32 Bug?

[Benjamin Herrenschmidt]

> If I find some time tonight, else tomorrow, I'll whip up a couple of
> patches:
> 
>  - One simpler re-arranging our Rx reset sequence and adding a test for
> the overflow bit at the end, printing out the results, etc... 
> 
>  - One that basically always reset the chip on overflow.

Actually, the second one is trivial, just modify gem_rxmac_interrupt()
as follow:

	if (rxmac_stat & MAC_RXSTAT_OFLW) {
		u32 smac = readl(gp->regs + MAC_SMACHINE);

		netdev_err(dev, "RX MAC fifo overflow smac[%08x]\n", smac);
		gp->net_stats.rx_over_errors++;
		gp->net_stats.rx_fifo_errors++;

-		ret = gem_rxmac_reset(gp);
+		ret = 1;
	}

And tell us if that makes a difference.

Cheers,
Ben.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/