Re: [sodaville] [PATCH v2 01/15] x86/e820: remove conditional earlymapping in parse_e820_ext

[H. Peter Anvin]

On 02/03/2011 12:09 PM, Andres Salomon wrote:
> 
> Daniel has a patch set that includes the following:
> 
> 0010-OLPC-add-XO-1-rtc-driver.patch
> 
> +++ b/arch/x86/platform/olpc/olpc.c
> @@ -311,6 +311,8 @@ static int __init add_xo1_platform_devices(void)
>  {
>         struct platform_device *pdev;
> 
> +       olpc_xo1_rtc_init();
> +
>         pdev = platform_device_register_simple("xo1-rfkill", -1, NULL,
>   0);
> 
> 
> This registers a specific rtc device for XO-1 machines (using the
> CS5536 RTC).  XO-1.5 uses ACPI and a Via-based board, so the RTC device
> should be handled there automatically.  The corner case is for machines
> where the OLPC DT is enabled, but OLPC_XO1_RTC is not enabled.  We
> still need to figure out what to do in that case, but I think it's more
> appropriate to focus on getting the PM and XO1_RTC stuff upstream
> first.  As of right now, it's the *only* case.  We'll change that, by
> getting OLPC_XO1_RTC upstream.

OK, so how about "you're -----d anyway, so please don't block other
development because you haven't gotten your own driver upstream?"

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/