Re: [PATCH 1/5] ARM: etm: Don't require clock control

From: Mark Brown
Date: Thu Feb 03 2011 - 07:45:50 EST


On Wed, Feb 02, 2011 at 06:54:19PM -0800, Arve Hj??nnev??g wrote:
> If clk_get fail, assume the etb does not need a separate clock.
>
> Signed-off-by: Arve Hj??nnev??g <arve@xxxxxxxxxxx>

Would it not be cleaner for the affected platforms to ensure that
clk_get() does the right thing here, for example by returning a dummy
clock? Otherwise we'll just silently carry on if we can't get a clock
we were supposed to which doesn't seem ideal.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/