Re: Regression: WARNINGS and lockdep spews in 2.6.38-rc3+(bisected).

[Peter Zijlstra]

On Thu, 2011-02-03 at 17:12 +0800, Yong Zhang wrote:
>  #ifdef CONFIG_LOCKDEP
> +       unsigned long flags;
> +
>         local_bh_disable();
>         lock_map_acquire(&timer->lockdep_map);
>         lock_map_release(&timer->lockdep_map);
> -       local_bh_enable();
> +       /* raw_local_irq_[save|restore] is to protect _local_bh_enable() */
> +       raw_local_irq_save(flags);
> +       _local_bh_enable();
> +       raw_local_irq_restore(flags);
>  #endif 

_why_ are you doing the raw_local_irq stuff? That's just weird, and that
comment isn't helping.

Also, calling _local_bh_enable() will leave pending softirqs, not
particularly nice

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/