Re: [PATCH 2/4] RTC: Fix rtc driver ioctl specific shortcutting

[Wolfram Sang]

On Wed, Feb 02, 2011 at 06:14:41PM -0800, John Stultz wrote:
> Some RTC drivers enable functionality directly via their ioctl method
> instead of using the generic ioctl handling code. With the recent
> virtualization of the RTC layer, its now important that the generic
> layer always be used.
> 
> This patch moved the rtc driver ioctl method call to after the generic
> ioctl processing is done. This allows hardware specific features or
> ioctls to still function, while relying on the generic code for handling
> everything else.

I guess the documentation should be updated, too. Currently it says:

Note that many of these ioctls need not actually be implemented by your
driver.  The common rtc-dev interface handles many of these nicely if your
driver returns ENOIOCTLCMD.  Some common examples:
...

That situation has changed after your patch.

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Attachment: signature.asc
Description: Digital signature