Re: [PATCH v2] altera_ps2: Add devicetree support

From: Thomas Chou
Date: Wed Feb 02 2011 - 18:35:09 EST


On 02/02/2011 11:39 PM, Grant Likely wrote:
On Wed, Feb 02, 2011 at 07:48:58PM +0800, Thomas Chou wrote:
On 02/02/2011 12:31 PM, Grant Likely wrote:
+static const struct of_device_id altera_ps2_match[] = {
+ { .compatible = "altr,ps2-1.0", },

I thought I had seen 'altera' instead of an abbreviation being used in
a previous patch. I don't care much whether 'altr' or 'altera' is
used, but I'd like to know that there is consensus from the Altera
users so that all the drivers use the same prefix.


We had discussed on nios2-dev mailing list, and decided to use
'altr' as Walter suggested that it saves space.

Is altr the stock ticker symbol? The convention is to either use the
stock ticker in all uppercase (although the uppercase bit hasn't been
consistently applied), or to use the full name in lowercase.

Yes, it is the stock ticker symbol. Then we shall follow the convention, and change it to uppercase.

- Thomas


g.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/