Re: [patch 00/28] Rework of the PTP support series core code

From: Richard Cochran
Date: Wed Feb 02 2011 - 03:17:19 EST


On Tue, Feb 01, 2011 at 01:50:55PM -0000, Thomas Gleixner wrote:
> The reason for this rework is that I got scared when reviewing:
> [PATCH V10 09/15] posix clocks: cleanup the CLOCK_DISPTACH macro

I am glad that you are taking the blame/credit ;)

> The patch is really too large and the risk of wreckage too high. So
> instead of whipping Richard through another round I reworked the
> series in the following way:
>
> 1) Split the CLOCK_DISPATCH cleanup in fine grained steps.

I didn't test or compile each of the little steps, but I have looked
the differences between where I landed with my V10 and this series.

> That allowed further cleanups and got rid of 200 lines of code and
> made a lot of functions static.

Yes, it looks even nicer than before, but I'll comment on a few small
points.

> Richard, can you please run that through your testing ? The PTP
> drivers apply on top of that.

I'll run my PTP tests today.

Thanks,
Richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/