[PATCH] [82/139] inotify: stop kernel memory leak on file creation failure

From: Andi Kleen
Date: Tue Feb 01 2011 - 19:44:35 EST


2.6.35-longterm review patch. If anyone has any objections, please let me know.

------------------
From: Eric Paris <eparis@xxxxxxxxxx>

commit a2ae4cc9a16e211c8a128ba10d22a85431f093ab upstream.

If inotify_init is unable to allocate a new file for the new inotify
group we leak the new group. This patch drops the reference on the
group on file allocation failure.

Reported-by: Vegard Nossum <vegard.nossum@xxxxxxxxx>
Signed-off-by: Eric Paris <eparis@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

---
fs/notify/inotify/inotify_user.c | 1 +
1 file changed, 1 insertion(+)

Index: linux-2.6.35.y/fs/notify/inotify/inotify_user.c
===================================================================
--- linux-2.6.35.y.orig/fs/notify/inotify/inotify_user.c
+++ linux-2.6.35.y/fs/notify/inotify/inotify_user.c
@@ -674,6 +674,7 @@ SYSCALL_DEFINE1(inotify_init1, int, flag
if (ret >= 0)
return ret;

+ fsnotify_put_group(group);
atomic_dec(&user->inotify_devs);
out_free_uid:
free_uid(user);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/