Re: [patch 04/28] posix-timers: Introduce clock_posix_cpu

[john stultz]

On Tue, 2011-02-01 at 13:51 +0000, Thomas Gleixner wrote:
> plain text document attachment
> (posix-timers-introduce-local-posix-cpu-clockid.patch)
> The CLOCK_DISPATCH() macro is a horrible magic. We call common
> functions if a function pointer is not set. That's just backwards.
> 
> To support dynamic file decriptor based clocks we need to cleanup that
> dispatch logic.
> 
> Create a k_clock struct clock_posix_cpu which has all the
> posix-cpu-timer functions filled in. After the cleanup the functions
> can be made static.
> 
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: John Stultz <john.stultz@xxxxxxxxxx>
> Cc: Richard Cochran <richard.cochran@xxxxxxxxxx>

Acked-by: John Stultz <johnstul@xxxxxxxxxx>

> ---
>  include/linux/posix-timers.h |    2 ++
>  kernel/posix-cpu-timers.c    |   12 ++++++++++++
>  2 files changed, 14 insertions(+)
> 
> Index: linux-2.6-tip/include/linux/posix-timers.h
> ===================================================================
> --- linux-2.6-tip.orig/include/linux/posix-timers.h
> +++ linux-2.6-tip/include/linux/posix-timers.h
> @@ -85,6 +85,8 @@ struct k_clock {
>  			   struct itimerspec * cur_setting);
>  };
> 
> +extern struct k_clock clock_posix_cpu;
> +
>  void register_posix_clock(const clockid_t clock_id, struct k_clock *new_clock);
> 
>  /* error handlers for timer_create, nanosleep and settime */
> Index: linux-2.6-tip/kernel/posix-cpu-timers.c
> ===================================================================
> --- linux-2.6-tip.orig/kernel/posix-cpu-timers.c
> +++ linux-2.6-tip/kernel/posix-cpu-timers.c
> @@ -1604,6 +1604,18 @@ static long thread_cpu_nsleep_restart(st
>  	return -EINVAL;
>  }
> 
> +struct k_clock clock_posix_cpu = {
> +	.clock_getres	= posix_cpu_clock_getres,
> +	.clock_set	= posix_cpu_clock_set,
> +	.clock_get	= posix_cpu_clock_get,
> +	.timer_create	= posix_cpu_timer_create,
> +	.nsleep		= posix_cpu_nsleep,
> +	.nsleep_restart	= posix_cpu_nsleep_restart,
> +	.timer_set	= posix_cpu_timer_set,
> +	.timer_del	= posix_cpu_timer_del,
> +	.timer_get	= posix_cpu_timer_get,
> +};
> +
>  static __init int init_posix_cpu_timers(void)
>  {
>  	struct k_clock process = {
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/