Re: [RFC Patch] virtio: export model and type in /sys

[Christoph Hellwig]

On Mon, Jan 31, 2011 at 10:53:00AM +0800, Amerigo Wang wrote:
> Our kdump script needs /sys/block/X/device/{vendor, model, type},
> but virtio devices don't have {model, type}, this patch adds them.
> Actually, I don't know how to fill the model field, other block devices
> seem read it from SCSI. Any comments?

It does not make any sense to fill this at all in virtio.  The
attributes are simply exporting the SCSI INQUIRY data, and do not make
any sense at all outside a SCSI context.  In fact the type field even
contains numbers from the scsi protocol spec that just don't make sense.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/