Re: [PATCH] virtio_blk: allow re-reading config space at runtime

From: Christoph Hellwig
Date: Tue Feb 01 2011 - 12:32:49 EST


On Thu, Jan 27, 2011 at 05:29:26PM +0200, Michael S. Tsirkin wrote:
> Yes but in that specific situation (double schedule before
> it runs once) discarding one change notification
> would not hurt at all.

Except that you can't easily do it. We can't simply reuse a work
structure embedded in say struct virtio_blk without first doing a
flush_work_sync/cancel_work_sync to remove it from the internal
workqueue.c queues. And those calls can sleep and thus can't be called
from interrupt context either.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/