Re: [PATCH 01/18] move do_timer() from kernel/timer.c intokernel/time/timekeeping.c

From: Thomas Gleixner
Date: Sat Jan 22 2011 - 04:45:21 EST


On Sat, 22 Jan 2011, Torben Hohn wrote:

Please add a sensible change log, why you move that code.

> Signed-off-by: Torben Hohn <torbenh@xxxxxx>
> ---
> kernel/time/timekeeping.c | 12 ++++++++++++
> kernel/timer.c | 13 -------------
> 2 files changed, 12 insertions(+), 13 deletions(-)
>
> diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
> index d27c756..546d82f 100644
> --- a/kernel/time/timekeeping.c
> +++ b/kernel/time/timekeeping.c
> @@ -946,3 +946,15 @@ struct timespec get_monotonic_coarse(void)
> now.tv_nsec + mono.tv_nsec);
> return now;
> }
> +
> +/*
> + * The 64-bit jiffies value is not atomic - you MUST NOT read it
> + * without sampling the sequence number in xtime_lock.
> + * jiffies is defined in the linker script...
> + */
> +void do_timer(unsigned long ticks)
> +{
> + jiffies_64 += ticks;
> + update_wall_time();
> + calc_global_load(ticks);
> +}

That also should make update_wall_time() static.

Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/