Re: [PATCH 2/2] staging: synaptics: Implement error hamdling forrmi4 touch regulator

[Greg KH]

On Fri, Jan 21, 2011 at 03:33:30PM -0800, Dmitry Torokhov wrote:
> On Fri, Jan 21, 2011 at 12:38:15PM -0800, Greg KH wrote:
> > On Fri, Jan 21, 2011 at 03:50:36PM +0530, Naveen Kumar G wrote:
> > > From: Naveen Kumar Gaddipati <naveen.gaddipati@xxxxxxxxxxxxxx>
> > > 
> > > Implement the error handling for regulator in synaptics
> > > rmi4 touch screen
> > > 
> > > Signed-off-by: Naveen Kumar Gaddipati <naveen.gaddipati@xxxxxxxxxxxxxx>
> > 
> > This patch has some fuzz and doesn't apply correctly.  Care to rediff it
> > and resend it?
> > 
> 
> Given that this driver is a [hopefully] dead-end placeholder should we
> even spend time cleaning this up? It would be better if effor was spent
> helping Synaptics folks clean up their generic driver...

I agree, but this looks like a new feature being added.  We also can't
keep people from sending patches in, and if Synaptics never comes
through with their new driver, hey, all the better :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/