Re: [cpuops cmpxchg double V2 1/4] Generic support forthis_cpu_cmpxchg_double

From: Mathieu Desnoyers
Date: Fri Jan 21 2011 - 14:32:48 EST


* Tejun Heo (tj@xxxxxxxxxx) wrote:
[...]
> > (note: packed here along with "aligned" does _not_ generate ugly
> > bytewise read/write memory ops like "packed" alone. The use of
> > "packed" is to let the compiler down-align the structure to the
> > value requested, instead of uselessly aligning it on 32-byte if it
> > chooses to.)
>
> Yeah, good point. :-)

For the records, I just noticed that "packed, aligned(8)" can generate unaligned
accesses on sparc64 by removing the padding between a "int" and a following
pointer. So we should not use it.

Thanks,

Mathieu

--
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/