Re: [PATCH 08/12] perf: Carve out mmap helpers for general use

From: Arnaldo Carvalho de Melo
Date: Fri Jan 21 2011 - 12:30:11 EST


Em Fri, Jan 21, 2011 at 04:09:31PM +0100, Borislav Petkov escreveu:
> From: Borislav Petkov <borislav.petkov@xxxxxxx>
>
> Export the mmap_read* helpers into tools/lib/perf/mmap.[ch]

Borislav, can you take a look at:

http://git.kernel.org/?p=linux/kernel/git/acme/linux-2.6.git;a=shortlog;h=refs/heads/perf/core

More specifically take a look at the function test__basic_mmap in:

http://git.kernel.org/?p=linux/kernel/git/acme/linux-2.6.git;a=blob;f=tools/perf/builtin-test.c;h=f03798a298b00b328a11f06ce20cc352d123ec28;hb=refs/heads/perf/core

434 /*
435 * This test will generate random numbers of calls to some getpid syscalls,
436 * then establish an mmap for a group of events that are created to monitor
437 * the syscalls.
438 *
439 * It will receive the events, using mmap, use its PERF_SAMPLE_ID generated
440 * sample.id field to map back to its respective perf_evsel instance.
441 *
442 * Then it checks if the number of syscalls reported as perf events by
443 * the kernel corresponds to the number of syscalls made.
444 */

I'll read the rest of your patchset to see if there are more things like
this.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/