Re: Bug in scheduler when using rt_mutex

[Yong Zhang]

On Fri, Jan 21, 2011 at 02:40:58PM +0100, Peter Zijlstra wrote:
> On Fri, 2011-01-21 at 20:24 +0800, Yong Zhang wrote:
> > > Index: linux-2.6/kernel/sched.c
> > > ===================================================================
> > > --- linux-2.6.orig/kernel/sched.c
> > > +++ linux-2.6/kernel/sched.c
> > > @@ -2624,6 +2624,8 @@ void sched_fork(struct task_struct *p, i
> > >  
> > >       if (!rt_prio(p->prio))
> > >               p->sched_class = &fair_sched_class;
> > > +     else
> > > +             p->se.vruntime = 0;
> > 
> > This can be moved to __sched_fork() 
> 
> But we cannot do it unconditionally, we want to inherit the parent's
> ->vruntime when we're a fair task clone.

Doesn't task_fork_fair()(which is called after __sched_fork())
take the inherit job?

Am I missing something?

Thanks,
Yong
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/