Re: [PATCH v4 3/5] MIPS/Perf-events: Fix event check in validate_event()

[Sergei Shtylyov]

Hello.

On 21-01-2011 11:19, Deng-Cheng Zhu wrote:

> Ignore events that are in off/error state or belong to a different PMU.

> This patch originates from the following commit for ARM by Will Deacon:

> - 65b4711ff513767341aa1915c822de6ec0de65cb
>      ARM: 6352/1: perf: fix event validation

>      The validate_event function in the ARM perf events backend has the
>      following problems:

>      1.) Events that are disabled count towards the cost.
>      2.) Events associated with other PMUs [for example, software events or
>          breakpoints] do not count towards the cost, but do fail validation,
>          causing the group to fail.

>      This patch changes validate_event so that it ignores events in the
>      PERF_EVENT_STATE_OFF state or that are scheduled for other PMUs.

> Changes:
> v4 - v3:
> o None
> v3 - v2:
> o Keep all mentioned commits in the form of number + title + original
> summary + (MIPS specific info when needed).
> v2 - v1:
> o Corrected the return value of the event check in validate_event().

   The patch changes should follow the --- tearline, not precede it.

> Acked-by: Will Deacon<will.deacon@xxxxxxx>
> Acked-by: David Daney<ddaney@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Deng-Cheng Zhu<dengcheng.zhu@xxxxxxxxx>
> ---

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/