RE: [PATCH] mfd: ab8500-gpadc Add new GPADC driver

[Arun MURTHY]

> > + * ab8500_gpadc_convert() - gpadc conversion
> > + * @input:	analog input to be converted to digital data
> > + *
> > + * This function converts the selected analog i/p to digital
> > + * data. Thereafter calibration has to be made to obtain the
> > + * data in the required quantity measurement.
> > + */
> > +int ab8500_gpadc_convert(struct ab8500_gpadc *di, u8 input)
> I would like this interface to change in order to remove the struct
> ab8500_gpadc
> from the struct ab8500. I.e not restrict the users to subdriver of
> ab8500.

The only clients for GPADC is the battery driver and the Audio Acc
detection. Both of these are sub-modules/clients of ab8500.
None other than these can use the GPADC.
Inputs to GPADC can only be one among the following:
/* GPADC source: From datasheet(ADCSwSel[4:0] in GPADCCtrl2) */
#define BAT_CTRL        0x01
#define BTEMP_BALL      0x02
#define MAIN_CHARGER_V  0x03
#define ACC_DETECT1     0x04
#define ACC_DETECT2     0x05
#define ADC_AUX1		0x06
#define ADC_AUX2		0x07
#define MAIN_BAT_V      0x08
#define VBUS_V          0x09
#define MAIN_CHARGER_C  0x0A
#define USB_CHARGER_C   0x0B
#define BK_BAT_V        0x0C
#define DIE_TEMP        0x0D

Henceforth in order to secure the usage of GPADC, and in order to
restrict it to only EM and AUDIO sub-module, the gpadc device struct
was added to ab8500 struct. Also that the exported function
ab8500_gpadc_convert has an argument struct ab8500_gpadc, which can
be obtained be dereferencing the struct ab8500. This is possible only
with the ab8500 and its clients, thereby securing the usage to
battery driver and audio acc detect.

Thanks and Regards,
Arun R Murthy
-------------
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/