Re: Locking in the clk API

From: Russell King - ARM Linux
Date: Fri Jan 21 2011 - 04:32:52 EST


On Thu, Jan 20, 2011 at 08:12:45PM -0800, Saravana Kannan wrote:
> In my opinion, the only major reason for needing atomic clk APIs was due
> to device_ops->suspend being atomic. Since that's not the case anymore,
> I really don't see a justification for atomic clocks. Sure, I might have
> missed some exceptions, but in that case we should make the atomic APIs
> an exception (add clk_enable_atomic) and not the norm.

The suspend method has never been atomic. It has always been able to
sleep. You're mistaken.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/