Re: [patch 36/37] tile: Use generic irq Kconfig

[Chris Metcalf]

On 1/19/2011 4:50 PM, Thomas Gleixner wrote:
> No functional change.
>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Chris Metcalf <cmetcalf@xxxxxxxxxx>
> ---
>  arch/tile/Kconfig |   16 ++++++----------
>  1 file changed, 6 insertions(+), 10 deletions(-)
>
> Index: linux-2.6/arch/tile/Kconfig
> ===================================================================
> --- linux-2.6.orig/arch/tile/Kconfig
> +++ linux-2.6/arch/tile/Kconfig
> @@ -1,22 +1,18 @@
>  # For a description of the syntax of this configuration file,
>  # see Documentation/kbuild/config-language.txt.
>  
> +config TILE
> +       def_bool y
> +       select HAVE_GENERIC_HARDIRQS
> +       select GENERIC_IRQ_PROBE
> +       select GENERIC_PENDING_IRQ if SMP
> +
>  [...]

I'm not sure it's legal to have two "config TILE" blocks in this Kconfig
file; there's already one further down.

Looking at other top-level arch Kconfigs, it does seem common to have the
"config $ARCH" block at the top, though, so if you want to move the
existing "config TILE" block to the top of the Kconfig as part of this
change, that's fine too.

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/