Re: [PATCH] pxa3xx: fix PXA GPIO IRQ handling

[Eric Miao]

On Tue, Jan 18, 2011 at 4:49 PM, Sven Neumann <s.neumann@xxxxxxxxxxxx> wrote:
> On Tue, 2011-01-18 at 08:15 -0800, Eric Miao wrote:
>> On Tue, Jan 18, 2011 at 3:47 AM, Lars-Peter Clausen <lars@xxxxxxxxxx> wrote:
>> > On 01/18/2011 09:18 AM, Sven Neumann wrote:
>> >> From: Lars-Peter Clausen <lars@xxxxxxxxxx>
>> >>
>> >> Set the "set_wake" field of the irq_chip struct before calling
>> >> set_irq_chip() for all of the IRQs, so that the compat handler
>> >> actually gets installed.
>>
>> Not really sure if this is necessary. Lennert has done the transition to
>> irq_data to those _set_wake() functions as well, so it should be OK
>> that compat handler doesn't get installed.
>>
>> Now I'm not against moving this above, just wondering if there were
>> any consequences/errors coming out?
>
> Well, our PXA300 device doesn't power up again when it should resume
> from suspend. Fine with me if this has been fixed upstream,

Yeah, that's true. Mind re-post with your SOB?

> but I would
> still like to get this patch into 2.6.37. I'll try to test upstream as
> soon as Linus releases 2.6.38-rc1...
>
>
> Sven
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/