Re: [PATCH v3] net: add Faraday FTMAC100 10/100 Ethernet driver

[Po-Yu Chuang]

Dear Eric,

On Thu, Jan 20, 2011 at 11:35 PM, Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote:
> Le jeudi 20 janvier 2011 Ã 23:30 +0800, Po-Yu Chuang a Ãcrit :
>
>> + Â Â /* push packet to protocol stack */
>> + Â Â netif_receive_skb(skb);
>> +
>> + Â Â netdev->stats.rx_packets++;
>> + Â Â netdev->stats.rx_bytes += skb->len;
>> +
>> + Â Â (*processed)++;
>> +
>> + Â Â return true;
>> +}
>> +
>
> Hmm, after call to netif_receive_skb(skb), you are not allowed to access
> skb anymore (maybe it was freed)
>
> netdev->stats.rx_packets++;
> netdev->stats.rx_bytes += skb->len;
> netif_receive_skb(skb);

Wow, you are totally right.

Thanks,
Po-Yu Chuang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/