Re: [PATCH 1/2] lockdep: move early boot local IRQ enable/disablestatus to init/main.c

[Peter Zijlstra]

On Thu, 2011-01-20 at 12:11 +0100, Tejun Heo wrote:
> Hello, guys.
> 
> These two patches remove both warnings.  The first warning was
> completely spurious.  The second lockdep one was triggered by
> on_each_cpu() enabling local IRQ too early.
> 
> I don't think percpu allocator itself malfunctioned.  There was no
> allocation failure.  It whines when percpu allocation fails but didn't
> in the log.  Other than calling vfree() early triggering the above
> condition, it worked okay.
> 
> So, it's either the early enabling of local IRQ by on_each_cpu()
> breaking something in the IRQ subsystem or something different.  Ingo,
> can you please see whether these two patches cure the panic too?

Why not use something like: system_state != SYSTEM_RUNNING ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/