Re: [PATCH] pohmelfs/dir.c: Remove unneeded mutex_unlock() frompohmelfs_rename()

From: Evgeniy Polyakov
Date: Thu Jan 20 2011 - 05:51:24 EST


On Thu, Jan 20, 2011 at 12:13:44AM +0300, Alexey Khoroshilov (khoroshilov@xxxxxxxxx) wrote:
> I do not see any reason for the mutex_unlock(&inode->i_mutex); in
> pohmelfs_rename().
>
>
> Found by Linux Driver Verification project (linuxtesting.org).

Yes, that's a bug, we already unlocked i_mutex in common path and should
not do that on error.

Thank you. Greg, please apply.

> Signed-off-by: Alexey Khoroshilov <khoroshilov@xxxxxxxxx>

Acked-by: Evgeniy Polyakov <zbr@xxxxxxxxxxx>

--
Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/