Re: [PATCH 0/2] HID: roccat: Add support for Arvo, small bugfix anda question

From: Jiri Kosina
Date: Thu Jan 20 2011 - 05:30:00 EST


On Thu, 6 Jan 2011, Stefan Achatz wrote:

> This patchset adds support for the Roccat Arvo keyboard.
> The driver is similar to my other roccat drivers.

Applied, thanks for the driver, Stefan.

> I'm now finished implementing new device support and my next step would
> be to abstract similarities to reduce code duplication.

That would be very welcome.

> Has the resulting file to be a module named like "roccat-common" that
> has to be selected as depencendy in Kconfig or is there another
> mechanism to hide this gratuitous decicion from the user?

Yes, I think this would be a reasonable implementation in this case.

--
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/