Cc: WANG Cong<amwang@xxxxxxxxxx>, Ingo Molnar<mingo@xxxxxxx> (commit_signer:8/43=19%,commit_signer:4/26=15%), Andrew Morton<akpm@xxxxxxxxxxxxxxxxxxxx> (commit_signer:7/43=16%,commit_signer:9/26=35%), Peter Zijlstra<a.p.zijlstra@xxxxxxxxx> (commit_signer:5/43=12%), Tejun Heo<tj@xxxxxxxxxx> (commit_signer:4/43=9%), Arnd Bergmann<arnd@xxxxxxxx> (commit_signer:3/43=7%), James Morris<jmorris@xxxxxxxxx> (commit_signer:6/26=23%), Kees Cook<kees.cook@xxxxxxxxxxxxx> (commit_signer:4/26=15%), Namhyung Kim<namhyung@xxxxxxxxx> (commit_signer:3/26=12%)
Pease don't do that.
On Wed, 19 Jan 2011 15:29:24 +0800
Amerigo Wang<amwang@xxxxxxxxxx> wrote:
These parameter setup functions should go to kernel/printk.c,
That makes sense.
and should also be under CONFIG_PRINTK.
Not so sure about that. console_loglevel pertains to the console
system more than to printk. And the console layer is present even when
CONFIG_PRINTK=n.
Now, it may be that console_loglevel never does anything useful when
CONFIG_PRINTK=n. In which case one wonders why the console code exists
when CONFIG_PRINTK=n.
Anyway. I didn't look at all this terribly hard. Please demonstrate
to us that you did do so :)